fix(deps): take the vitest fix for the path-traversal advisory - #591
Merged
Conversation
CI went red on every open branch, not just one: GHSA-82fw-gwwq-j7x9 was published against `vitest >=2.1.0 <4.1.11` — path traversal / arbitrary file read through @vitest/mocker's redirect mock. The catalog was on ^3.2.6. Raised to ^4.1.11 rather than added to KNOWN in scripts/check-advisories.mjs. The allowlist there is for advisories with nowhere to go — its two entries are inside Expo's own dependency tree, where forcing a version is how a working mobile build stops working. That file says so itself: "when a real fix appears upstream the entry stops being true, and the note below it stops being an excuse". A fix exists here, so the excuse would have been false the day it was written. A test-runner major is worth checking rather than assuming, so all three suites were run against it before committing: 444 shared, 777 web, 382 mobile — all pass, no config or test changes needed. `pnpm audit` now reports only the two known Expo entries. Deliberately its own PR. It blocks every branch, so it should not ride inside one of them, and a bump of the tool that runs the tests deserves to be reviewable on its own. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011rgEMvYYi4Egj99dVtvm6E
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI is red on every open branch, not just one.
GHSA-82fw-gwwq-j7x9was published againstvitest >=2.1.0 <4.1.11— path traversal / arbitrary file read through@vitest/mocker's redirect mock. The catalog was on^3.2.6.Why the bump and not the allowlist
scripts/check-advisories.mjsoffers both routes, and itsKNOWNlist is for advisories with nowhere to go — its two entries sit inside Expo's own dependency tree, where forcing a version is how a working mobile build stops working.That file states the rule itself:
A fix exists here. An allowlist entry would have been false the day it was written.
Verified, not assumed
A test-runner major deserves a check before it lands:
packages/sharedapps/webapps/mobileapps/admintypecheckNo config or test changes were needed.
pnpm auditnow reports only the two known Expo entries (uuid,decode-uri-component).Why its own PR
It blocks every branch, so it should not ride inside one of them — and a bump of the tool that runs the tests deserves to be reviewable on its own.
🤖 Generated with Claude Code
https://claude.ai/code/session_011rgEMvYYi4Egj99dVtvm6E