fix: using null as an array offset is deprecated, use an empty string instead - #2135
Open
ddevsr wants to merge 2 commits into
Open
fix: using null as an array offset is deprecated, use an empty string instead#2135ddevsr wants to merge 2 commits into
ddevsr wants to merge 2 commits into
Conversation
jakejackson1
added a commit
to GravityPDF/mpdf
that referenced
this pull request
Sep 7, 2026
The property was declared without a default, so it is null on any Mpdf whose constructor has not run. ResourceWriter and BackgroundWriter both reach for it with count(), which is a TypeError on PHP 8. Mirrors mpdf#2135, less its SvgTest rewrite: the deprecation that PR is named after comes from a null $gs subscript, not from $extgstates, and upstream has since fixed that cause in 2dc0381, which gravitypdf already carries. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.