Skip to content

Fix MSVC + CUDA + Ninja multi-config command line parsing - #2764

Open
nikolaseu wants to merge 2 commits into
mozilla:mainfrom
nikolaseu:fix-msvc-cuda-ninja-multi-config
Open

Fix MSVC + CUDA + Ninja multi-config command line parsing#2764
nikolaseu wants to merge 2 commits into
mozilla:mainfrom
nikolaseu:fix-msvc-cuda-ninja-multi-config

Conversation

@nikolaseu

Copy link
Copy Markdown

Fixes #2470

@codecov-commenter

codecov-commenter commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.50000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.38%. Comparing base (c037e11) to head (3b7e6c1).

Files with missing lines Patch % Lines
src/compiler/nvcc.rs 97.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2764      +/-   ##
==========================================
+ Coverage   74.32%   74.38%   +0.05%     
==========================================
  Files          71       71              
  Lines       40789    40864      +75     
==========================================
+ Hits        30318    30395      +77     
+ Misses      10471    10469       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq

codspeed-hq Bot commented Jul 28, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 58 untouched benchmarks
⏩ 6 skipped benchmarks1


Comparing nikolaseu:fix-msvc-cuda-ninja-multi-config (3b7e6c1) with main (c037e11)

Open in CodSpeed

Footnotes

  1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@sylvestre
sylvestre force-pushed the fix-msvc-cuda-ninja-multi-config branch from a865fc6 to 3b7e6c1 Compare July 29, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CUDA + MSVC + Ninja Multi-Config error: Could not parse shell line

2 participants