Repository navigation
Restore the staticmethod decorator of the accessibility model's bug predicate - #7597
Merged
Merged
Conversation
…redicate When get_rollback_point was added to the accessibility model, it was inserted between the @staticmethod decorator and __is_accessibility_bug, so the predicate became an instance method without a self parameter (making training fail with a TypeError) and get_rollback_point became a static method with one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
get_rollback_pointwas added to the accessibility model (3d39edb), it was inserted between the@staticmethoddecorator and__is_accessibility_bug, so the predicate became an instance method without aselfparameter andget_rollback_pointbecame a static method with one.This made the accessibility model training fail with:
(https://community-tc.services.mozilla.com/tasks/EjCdBQ4FS62LGyG7T_Nvow)