Skip to content

Restore the staticmethod decorator of the accessibility model's bug predicate - #7597

Merged
marco-c merged 1 commit into
mozilla:masterfrom
marco-c:fix-accessibility-staticmethod
Nov 19, 2026
Merged

marco-c merged 1 commit into
mozilla:masterfrom
marco-c:fix-accessibility-staticmethod

Conversation

@marco-c

@marco-c marco-c commented Nov 19, 2026

Copy link
Copy Markdown
Collaborator

When get_rollback_point was added to the accessibility model (3d39edb), it was inserted between the @staticmethod decorator and __is_accessibility_bug, so the predicate became an instance method without a self parameter and get_rollback_point became a static method with one.

This made the accessibility model training fail with:

TypeError: AccessibilityModel.__is_accessibility_bug() takes 1 positional argument but 2 were given

(https://community-tc.services.mozilla.com/tasks/EjCdBQ4FS62LGyG7T_Nvow)

…redicate

When get_rollback_point was added to the accessibility model, it was inserted
between the @staticmethod decorator and __is_accessibility_bug, so the
predicate became an instance method without a self parameter (making training
fail with a TypeError) and get_rollback_point became a static method with one.
@marco-c
marco-c marked this pull request as ready for review November 19, 2026 22:05
@marco-c
marco-c requested a review from a team as a code owner November 19, 2026 22:05
@marco-c
marco-c merged commit c1001cf into mozilla:master Nov 19, 2026
4 of 13 checks passed
@marco-c
marco-c deleted the fix-accessibility-staticmethod branch November 19, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant