Repository navigation
Conversation
Member
|
We have related WIP (#7247), whatever solution works here, we should apply it there. |
Contributor
Author
I'm asking W&B support to verify this. If it unblocks the evals, we should probably just land this. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under W&B Workload Identity Federation, weave keeps using the W&B access token it exchanged until the token's stated expiry, but W&B stops accepting it about an hour after the exchange. It answers with 401, then 403
Project not found. The runtime already rewrites the identity token file every 30 min, but weave doesn't exchange it again while its cached token looks valid.This hits any agent process that runs longer than about an hour:
dataset-evalrun, the parent's final Weave writes were dropped, so the evaluation never closed and showed no metrics.bug-fixhit the same 401s.After each identity-token refresh,
wandb_wifnow drops weave's cached access token, in memory and in its credentials file. The next request then exchanges the fresh identity token. This relies on private weave internals, so it is a stopgap until W&B fixes the token lifetime. If those internals change, it logs an error and the token-file refresh keeps working.To verify: a deployed run longer than 2h shows no 401/403 errors in Sentry and a finished evaluation in Weave.
fixes #7523