Skip to content

feat(firefox): share opt-in build preparation - #7370

Draft
jwmossmoz wants to merge 6 commits into
mozilla:masterfrom
jwmossmoz:relops/hackbot-firefox-ci-build
Draft

jwmossmoz wants to merge 6 commits into
mozilla:masterfrom
jwmossmoz:relops/hackbot-firefox-ci-build

Conversation

@jwmossmoz

@jwmossmoz jwmossmoz commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Share build preparation so bug-fix bootstraps its toolchain before its first native build, and build-repair selects CI task settings explicitly.

Why

Downloaded Oct 3–Nov 2 logs show missing-Rust build results in 78 of 133 bug-fix runs and 16 ignored-directory results. Autowebcompat's artifact builds succeeded in 49 of 51 calls, so its build configuration stays unchanged. These are logged tool results, not a complete audit of builds run through Bash.

Changes

  • Bug-fix sets bootstrap_before_build. build_firefox then runs mach bootstrap once before the first build and keeps the mozconfig. Triage-only runs do no setup. An explicit bootstrap_firefox call counts, so artifact and Android selection still work. A setup failure stops the build.
  • Move CI toolchain setup from build-repair to agent_tools.firefox.ci_build behind configure_ci_build(). A CI setup counts as bootstrapped, so bootstrap never runs over CI's toolchains. The CI environment goes to the build process only, not to os.environ.
  • build_firefox returns failure when mach ignores the requested directory, even if mach exits 0.

Validation

  • macOS: agent-tools 96 passed, 1 failed (test_bootstrap_runs_without_controlling_terminal needs Linux /proc); build-repair 56 passed; bug-fix 12 passed, 4 skipped.
  • Ruff check (CPY001 excluded) and format pass.
  • Codex autoreview (P0–P2) of the rebased candidate: one finding (bootstrap over CI toolchains), fixed in 51761d4.
  • Earlier, on the first version: Linux container shared Firefox tests passed. Not repeated after the rebase.

Other

No full-agent Firefox or Cloud Run run validates this update. Remote sccache comes in a follow-up. Keep this PR draft until the native preparation path has an end-to-end Firefox check.

@marco-c

marco-c commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator

I don't know if we want this for all hackbot agents. It makes sense for CI agents, but not so much for generic ones? For generic ones, I imagine only sccache, etc.

@jwmossmoz

Copy link
Copy Markdown
Contributor Author

I don't know if we want this for all hackbot agents. It makes sense for CI agents, but not so much for generic ones? For generic ones, I imagine only sccache, etc.

Makes sense, didn't know what other agents were doing in relation to building similar to how it's done in CI, so we can focus sccache and faster checkouts.

@jwmossmoz jwmossmoz changed the title feat(firefox): share CI build setup across agents feat(firefox): share opt-in build preparation Nov 3, 2026
@jwmossmoz
jwmossmoz force-pushed the relops/hackbot-firefox-ci-build branch from cca7097 to 5e0973c Compare November 19, 2026 20:11

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants