Repository navigation
Bug 2084149 - #2832
Merged
Merged
Bug 2084149#2832
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the changes that filter inaccessible bugs before duplicate-search result limits.
No open issues 🎉
What changed in this PR
Addresses Bug 2084149 by filtering inaccessible bugs before possible-duplicate result limits, preventing hidden summary matches from consuming result slots.
Changes:
- Adds a SQL visibility predicate matching existing bug-access rules.
- Filters search candidates before SQL limiting and resolved duplicate targets before final truncation.
- Adds REST regression tests for privileged, CC-only, and anonymous users, including boolean-mode probes; SQL-cutoff coverage still needs six higher-ranked hidden candidates.
| File | Description |
|---|---|
| qa/t/rest_bug_possible_duplicates.t | Adds regression tests for restricted-summary privacy and privileged, CC-only, and anonymous visibility in possible-duplicate searches. |
| Bugzilla/User.pm | Adds and documents visible_bugs_sql to express bug-visibility rules as a SQL predicate. |
| Bugzilla/Bug.pm | Applies visibility filtering before SQL limiting and checks resolved duplicate targets before final result truncation. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review+ carried over from private pull request
https://bugzilla.mozilla.org/show_bug.cgi?id=2084149