Repository navigation
Bug 2094200 - [MENTIONS] Make the banner bigger for needinfo mentions so it is more noticable - #2831
Merged
Merged
Conversation
dklawren
commented
Nov 17, 2026
Collaborator
… so it is more noticable
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the mention-warning styling and needinfo emphasis changes.
No open issues 🎉
What changed in this PR
Makes the comment editor’s mention warning more noticeable, with a larger banner and stronger emphasis on needinfo requests.
Changes:
- Increases banner spacing, border prominence, and font size, with added spacing between warning paragraphs.
- Bolds the needinfo heading while preserving HTML encoding.
| File | Description |
|---|---|
| skins/standard/text-editor.css | Enlarges the mention warning and adds paragraph spacing. |
| js/text-editor.js | Emphasizes the needinfo heading with bold markup. |
Review effort: Balanced
Xzzz
approved these changes
Nov 18, 2026
Xzzz
left a comment
Collaborator
There was a problem hiding this comment.
lgtm, the bold title and larger box make the needinfo warning much more visible, have to say. Thank you! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.