Repository navigation
Bug 2086124 - [HACKBOT] Structured metadata on comments - #2819
Merged
Merged
Conversation
t/critic.t failed in CI: the extension added hand-written character classes, a `no warnings`, and a `$+[0]` above the counts in t/.perlcritic-history. - Use POSIX classes with /a, which match the same ASCII characters. - Capture the comment text in the front matter regex instead of reading $+[0]. - Drop `no warnings 'redefine'`: nothing defines Bugzilla::Comment::hackbot before the extension does.
Attachment, duplicate and other typed comments are formatted without the comment_body_full hook, so a front matter block in them stayed visible while the header still showed the agent and hid its tag. Only plain comments are parsed now. The DB test adds an attachment with a block in its comment.
Collaborator
Author
|
It looks like the current test failures are not related to the code. @dklawren Please trigger rerun later. I don’t have permission to do it. |
dklawren
requested changes
Nov 10, 2026
Saving an inline edit put the HTML of the raw text in the page, so a Hackbot comment showed its front matter block until reload. The response is now rendered from body_full, which applies the comment_body_full hook, like the bug page.
dklawren
requested changes
Nov 12, 2026
With the comment_body_full hook, extensions can hide part of a comment from the REST `text` field, as the Hackbot extension does with its front matter. `raw_text` still has the stored text.
Collaborator
Author
|
The fixes are in. I didn’t trigger CI because these are just minor document and CSS updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug 2086124 - [HACKBOT] Structured metadata on comments
hackbot_useradmin param to enable this feature