fix(install): resolve engine aliases in /install and moshcode install - #525
Merged
Merged
Conversation
`/install mimo` and `moshcode install cc` looked the token up as a raw ENGINES key and printed "unknown engine", while `/agents mimo`, `/start cc` and `moshcode upgrade cc` all took the alias. One resolver (resolveInstallable: engine name or alias, else tool key) now backs the pit's /install and the CLI's install and uninstall, so the name that starts an engine is also the name that installs it. Prototype names still print the unknown-target line. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
ThreatCrush Security Scan0 finding(s) in the 4 file(s) this pull request changes. Nothing in the files this pull request changes. 101 pre-existing finding(s) elsewhere in the repository — **HIGH/CRITICAL**: 8 | **MEDIUM**: 82 | **LOW**: 11Not introduced by this pull request. The full set is in the Security tab.
…and 81 more. Full results in the Security tab. Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #524, which was merged before this commit reached the branch.
/install mimoandmoshcode install cclooked the token up as a rawENGINESkey and printed "unknown engine", while/agents mimo,/start ccandmoshcode upgrade ccall took the alias. One resolver (resolveInstallablein src/tools.mjs: engine name or alias, else tool key) now backs the pit's/installand the CLI'sinstallanduninstall, so the name that starts an engine is also the name that installs it. Prototype names such asconstructorstill print the unknown-target line.Verified by hand:
moshcode install mimoprints "installing mimocode", the pit's/install mimoruns the mimocode installer,/install constructorstill says unknown. Unit test added in test/tools.test.mjs.🤖 Generated with Claude Code