fix(result): incomplete test xp lost when the next result is zen (@boergeson) - #8381
Open
boergeson wants to merge 2 commits into
Open
fix(result): incomplete test xp lost when the next result is zen (@boergeson)#8381boergeson wants to merge 2 commits into
boergeson wants to merge 2 commits into
Conversation
monkeytypegeorge
added
backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Abandoned tests are pushed to
incompleteTestsand sent with the next saved result. If that next result is a zen test the backend returns 0 xp straight away, but the frontend still clears the list after saving, so the xp for the abandoned tests is just gone. Thats what the reporter sees: quit a custom test, finish a zen test, no incomplete xp, and none on the next words/time test either.Zen still gets no xp for the test itself, but the incomplete part is now awarded. The list cant just be carried over on the frontend because the result spacing check counts
incompleteTestSeconds.Added a spec, on master it gets 0, here it gets the 5 xp from the incomplete test in the fixture.
Closes #8170