fix(monkey-power): shake reset never cancelled, spark colors not padded (@boergeson) - #8380
Open
boergeson wants to merge 3 commits into
Open
fix(monkey-power): shake reset never cancelled, spark colors not padded (@boergeson)#8380boergeson wants to merge 3 commits into
boergeson wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two small things in monkey power:
reset()deletedctx.resetTimeOutand then calledclearTimeoutwith it, so the 2s shake reset fromaddPowerwas never cancelled. Swapped the two lines.randomColor()built the hex string without padding, so any channel under 16 gave a 3 to 5 char color like#fa2that isnt what was meant. Channels are now padded to two digits.Added a spec for both,
randomColoris exposed through__testinglike a few other modules do. Both tests fail on master and pass here.Closes #8362