fix(input): separate copy and paste event listeners (@yasith-tharuka) - #8371
Open
yasith-tharuka wants to merge 1 commit into
Open
fix(input): separate copy and paste event listeners (@yasith-tharuka)#8371yasith-tharuka wants to merge 1 commit into
yasith-tharuka wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes broken copy/paste prevention on the hidden words input by registering real DOM event types (space-separated strings were treated as one unknown event name, so handlers never fired).
Changes:
- Split
"copy paste"into separate"copy"+"paste"addEventListenerregistrations. - Removed the dead
"select selectstart"listener block (caret/selection handling already done viaselectionchange).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
frontend/src/ts/input/listeners/misc.ts. Previously,addEventListener("copy paste", ...)andaddEventListener("select selectstart", ...)were used, but browsers treat space-separated strings as single unknown event names, preventing the handlers from firing.copyandpasteinto independentaddEventListenercalls withpreventDefault().select selectstartlistener block since caret positioning is already handled byselectionchange.Checks
Closes #8361