refactor: update Makefile and improve README, add pinger functionality - #20
Conversation
- Simplified Makefile to remove unnecessary GITCOMMIT variable. - Enhanced README with installation instructions and usage examples. - Refactored main.go to improve error handling and streamline the pinging process. - Added pinger.go for IP address resolution and pinger creation. - Removed main_test.go and added pinger_test.go for testing the new pinger functionality. - Updated go.mod and go.sum to include new dependencies.
PR Reviewer Guide 🔍(Review updated until commit 0d617a3)Here are some key observations to aid the review process:
|
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Persistent review updated to latest commit 7e9d4e8 |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Persistent review updated to latest commit d55162f |
|
Persistent review updated to latest commit 1e51cd1 |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
|
Persistent review updated to latest commit 0d617a3 |
PR Code Suggestions ✨No code suggestions found for the PR. |



User description
PR Type
Enhancement, Tests, Documentation
Description
Integrates
flagrunfor CLI executionRefactors IP resolution and pinger creation
Adds IPv4 and IPv6 pinger tests
Expands installation, configuration, and metrics documentation
Diagram Walkthrough
File Walkthrough
main.go
Integrate flagrun into plugin executionmain.go
flagrunRuninterface and exit statusespinger.go
Add protocol-aware pinger creationpinger.go
pinger_test.go
Test IPv4 and IPv6 pinger setuppinger_test.go
Makefile
Simplify builds and add lintingMakefile
lintand expands phony targetsREADME.md
Expand Japanese usage and metrics documentationREADME.md
go.mod
Update CLI and networking dependenciesgo.mod
flagrundependencystatsand networking dependencies