Repository navigation
DRIVERS-3251: Preserve version-to-name mapping in Client Metadata - #1975
Merged
prestonvasquez merged 9 commits intoSep 28, 2026
Conversation
prestonvasquez
force-pushed
the
handshake/drivers-3251-preserver-verion-to-name-mapping
branch
4 times, most recently
from
September 11, 2026 19:54
5a9b8a6 to
ae7083f
Compare
…tadata Require driver.name and driver.version entries to correspond one-to-one by index, with an absent field contributing an empty entry that MUST NOT be stripped. Clarify that duplicate detection compares whole DriverInfoOptions objects rather than individual fields.
Adds Test 10 covering the index correspondence between driver.name and driver.version, and updates Tests 1 and 2 so the delimiter is described as being appended unconditionally.
Adds Test 11 asserting that appending a DriverInfoOptions whose fields contain the delimiter raises an error and leaves the accumulated metadata unchanged. This cannot be expressed as a unified test because handshake commands are excluded from command monitoring.
prestonvasquez
force-pushed
the
handshake/drivers-3251-preserver-verion-to-name-mapping
branch
from
September 11, 2026 20:01
ae7083f to
074dbba
Compare
prestonvasquez
changed the title
prestonvasquez
marked this pull request as ready for review
September 11, 2026 20:31
blink1073
approved these changes
Sep 22, 2026
blink1073
left a comment
blink1073
left a comment
Member
There was a problem hiding this comment.
I'm approving as a spec owner and second implementor - our PR is ready to merge: mongodb/mongo-python-driver#3054
vbabanin
reviewed
Sep 25, 2026
Co-authored-by: Viacheslav Babanin <frest0512@gmail.com>
Co-authored-by: Viacheslav Babanin <frest0512@gmail.com>
…' of github.com:prestonvasquez/specifications into handshake/drivers-3251-preserver-verion-to-name-mapping
Member
|
Spec changes LGTM, I'm waiting on final review in PyMongo with the prose tests changes. |
blink1073
self-requested a review
September 28, 2026 15:20
blink1073
approved these changes
Sep 28, 2026
prestonvasquez
deleted the
handshake/drivers-3251-preserver-verion-to-name-mapping
branch
September 28, 2026 17:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRIVERS-3251
Please complete the following before merging:
Drivers should require that entries in
client.driver.nameandclient.driver.versioncorrespond 1-1 by index so that splitting both fields on the delimiter recovers which version belongs to which library. This will allow downstream teams to deterministically parse data from handshakes for telemetry.clusters).