Skip to content

chore(NODE-7833): 'latest' server binary behind s3 - #5074

Merged
tadjik1 merged 26 commits into
mainfrom
NODE-7833/latest-binary-behind-s3
Oct 15, 2026
Merged

tadjik1 merged 26 commits into
mainfrom
NODE-7833/latest-binary-behind-s3

Conversation

@johnmtll

@johnmtll johnmtll commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Description

Summary of Changes

  1. Updates Evergreen config to assume the necessary role to retrieve the nightly server build (latest) which is now behind a private S3 bucket.
  2. Updates local integration test run documentation to note aws profile setup as a prerequisite, and callout that omitting the VERSION will pull latest-stable instead of latest.
  3. Various tests are incompatible with v20/v12 of ubuntu/debian given the latest DET changes, these tests have been updated to use a later version.
Notes for Reviewers
  • AWS Profile setup tested as a prerequisite for pulling latest.

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@johnmtll
johnmtll requested a review from a team as a code owner October 8, 2026 14:30
Copilot AI balanced review requested due to automatic review settings October 8, 2026 14:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The local testing guide incorrectly presents internal AWS access as mandatory for stable server builds.

1 open finding
What changed in this PR

Adds AWS role access for nightly MongoDB binaries and documents local setup.

Changes:

  • Assumes the required AWS role in Evergreen.
  • Documents nightly versus stable server setup.
File Description
.evergreen/​config.in.yml Adds role assumption to source config.
.evergreen/​config.yml Updates generated Evergreen config.
test/​readme.md Documents local AWS setup and version defaults.
AGENTS.md Updates integration-test guidance.

🧠 Review effort: Balanced


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

Comment thread test/readme.md
@johnmtll
johnmtll force-pushed the NODE-7833/latest-binary-behind-s3 branch from 82f836d to 00a4927 Compare October 8, 2026 14:32
@johnmtll
johnmtll marked this pull request as draft October 8, 2026 14:34
@johnmtll
johnmtll force-pushed the NODE-7833/latest-binary-behind-s3 branch from 2075212 to 9653c7c Compare October 8, 2026 15:02
@johnmtll
johnmtll force-pushed the NODE-7833/latest-binary-behind-s3 branch from c546bad to 9242f98 Compare October 8, 2026 18:53
@johnmtll
johnmtll force-pushed the NODE-7833/latest-binary-behind-s3 branch from 9242f98 to 196e781 Compare October 8, 2026 19:06
@johnmtll
johnmtll marked this pull request as ready for review October 14, 2026 07:12
@PavelSafronov PavelSafronov self-assigned this Oct 14, 2026
@PavelSafronov PavelSafronov added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Oct 14, 2026
Comment thread .evergreen/generate_evergreen_tasks.js Outdated
Comment thread .evergreen/generate_evergreen_tasks.js Outdated
Comment thread .evergreen/config.yml Outdated
Comment thread .evergreen/generate_evergreen_tasks.js
Comment thread test/readme.md
johnmtll added a commit that referenced this pull request Oct 14, 2026
@johnmtll
johnmtll force-pushed the NODE-7833/latest-binary-behind-s3 branch from 46a3350 to 6c18d9e Compare October 14, 2026 16:42

@PavelSafronov PavelSafronov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and CI is green, approving!

@PavelSafronov PavelSafronov added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Oct 14, 2026

@tadjik1 tadjik1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @johnmtll !

@tadjik1
tadjik1 merged commit ef6f6f3 into main Oct 15, 2026
34 checks passed
@tadjik1
tadjik1 deleted the NODE-7833/latest-binary-behind-s3 branch October 15, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team Review Needs review from team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants