Repository navigation
CLOUDP-469562: Fix git-version.sh path in docker-build.sh - #145
Merged
apokhyla-inc merged 1 commit intoOct 30, 2026
Merged
Conversation
Contributor
Author
|
only 2 tasks are failing, these preexist my changes, most likely due to OS eol |
apokhyla-inc
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://jira.mongodb.org/browse/CLOUDP-469562
Description
Follow-up to #144 / #142:
build/package/docker/docker-build.shresolvesgit-version.shrelative to its own directory (build/package/docker/), but the script lives inbuild/package/— so thepkg_smoke_tests_dockerrelease QA task fails with./git-version.sh: No such file or directory(task log).Matches the working atlascli version (mongodb/mongodb-atlas-cli
build/package/docker/docker-build.sh:19), which resolves../git-version.sh.Testing
pkg_smoke_tests_dockerQA task green on the next release run