Repository navigation
PYTHON-6149 Add maxPoolSize=0 regression test and fix docstring - #3132
Closed
aclark4life wants to merge 7 commits into
Closed
aclark4life wants to merge 7 commits into
aclark4life wants to merge 7 commits into
Conversation
7 tasks
Contributor
Author
|
Superseded: changes pushed directly to #3099 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-6149
Follow-up to #3099.
Changes in this PR
maxPoolSize=0/NonewithminPoolSize=5and for the still-raisingmaxPoolSize=10, minPoolSize=20case.max_pool_sizedocstring: "Cannot be 0" contradicted the pool behavior (maxPoolSize=0has meant unlimited, asserted bytest_max_pool_size_zero); it now says a value of 0 orNonemeans no limit.Test Plan
DB_IP=… DB_PORT=… pytest test/test_pooling.py -k max_pool_size: 7 passed with the fix; the new test fails against the old guard (max_pool_size is not None).Checklist
Checklist for Author
Checklist for Reviewer