Skip to content

PYTHON-6151 Define exclude-newer in pyproject.toml - #3103

Merged
aclark4life merged 5 commits into
mongodb:mainfrom
aclark4life:PYTHON-6151-exclude-newer
Oct 7, 2026
Merged

aclark4life merged 5 commits into
mongodb:mainfrom
aclark4life:PYTHON-6151-exclude-newer

Conversation

@aclark4life

@aclark4life aclark4life commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

PYTHON-6151

Changes in this PR

  • Add exclude-newer = "7 days" to [tool.uv] in pyproject.toml.
  • Regenerate uv.lock to record the cutoff in its [options] block.
  • Update CONTRIBUTING.md
  • passed exclude_newer: "" to the uv lock update action

Test Plan

  • uv lock --check passes before and after the lockfile regeneration.

Checklist

Checklist for Author

  • Did you update the changelog (if necessary)?
  • Is the intention of the code captured in relevant tests?
  • If there are new TODOs, has a related JIRA ticket been created?

Checklist for Reviewer

  • Does the title of the PR reference a JIRA Ticket?
  • Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?)
  • Have you checked for spelling & grammar errors?
  • Is all relevant documentation (README or docstring) updated?

@aclark4life
aclark4life requested a review from a team as a code owner October 7, 2026 17:56
@aclark4life
aclark4life requested review from sleepyStick and a balanced review from Copilot October 7, 2026 17:56

This comment was marked as resolved.

@aclark4life
aclark4life force-pushed the PYTHON-6151-exclude-newer branch from ba9ea04 to b2914a4 Compare October 7, 2026 17:58
Comment thread pyproject.toml Outdated
required-version = "==0.12.12"
# Skip dependency releases newer than 7 days. Defined here, not in CI env,
# so every uv invocation sees the same cutoff. The span floats, so no date
# to bump.

@sleepyStick sleepyStick Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think we can be more concise in this comment, something like:
Skip dependency releases newer than 7 days. Defining it here keeps every uv invocation on the same cutoff.

@aclark4life
aclark4life force-pushed the PYTHON-6151-exclude-newer branch 4 times, most recently from b45515b to 5d4ea1e Compare October 7, 2026 18:37
The uv-lock-update workflow exported UV_EXCLUDE_NEWER, so the lock and
check invocations saw different configs and uv lock --check failed.
Define the 7 day cutoff in pyproject.toml so every uv invocation reads
the same config.
@aclark4life
aclark4life force-pushed the PYTHON-6151-exclude-newer branch from 5d4ea1e to 8ae6f0c Compare October 7, 2026 18:38
@aclark4life
aclark4life requested review from sleepyStick and a balanced review from Copilot October 7, 2026 18:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The configuration, lockfile, documentation, and automation changes are consistent.

0 open findings

1 resolved since last review

🧠 Review effort: Balanced

@codecov

codecov Bot commented Oct 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@aclark4life
aclark4life merged commit 381e588 into mongodb:main Oct 7, 2026
91 of 93 checks passed
@aclark4life
aclark4life deleted the PYTHON-6151-exclude-newer branch October 7, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants