Repository navigation
PYTHON-6114 Exclude mod_wsgi from Windows dependency resolution - #3085
Merged
Merged
Conversation
blink1073
force-pushed
the
PYTHON-6114-win32
branch
2 times, most recently
from
October 1, 2026 10:35
ecbd7bb to
3350d4e
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The implementation retains the dependency group and lock entries that the PR description says must be removed.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Adds Windows exclusion markers for the test-only mod_wsgi dependency while raising its minimum version.
Changes:
- Excludes
mod_wsgion Windows. - Raises its minimum version to 5.0.2.
- Updates lock-file markers, but does not perform the migration described in the PR.
| File | Description |
|---|---|
pyproject.toml |
Updates the dependency group and platform marker. |
uv.lock |
Records the new constraint and Windows exclusion. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
blink1073
force-pushed
the
PYTHON-6114-win32
branch
from
October 1, 2026 11:00
3350d4e to
b2a9558
Compare
blink1073
force-pushed
the
PYTHON-6114-win32
branch
2 times, most recently
from
October 1, 2026 11:19
d01b024 to
538fad7
Compare
Min-deps tasks re-resolve the whole project with uv --resolution=lowest-direct. The universal lock must resolve every dependency group on every platform, and uv can only resolve mod_wsgi by building its sdist, which fails on Windows without an Apache installation. Move the constraint to requirements/mod_wsgi.txt (managed by Dependabot) and install it on demand in the mod_wsgi workflows.
blink1073
force-pushed
the
PYTHON-6114-win32
branch
from
October 1, 2026 11:27
538fad7 to
08b7f97
Compare
blink1073
marked this pull request as ready for review
October 1, 2026 11:32
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
NoahStapp
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-6114
Changes in this PR
Follow-up to #3069 to fix
mod_wsgihandling on Windows, which is not supported on that platform.Removes the
mod_wsgidependency group: the constraint moves torequirements/mod_wsgi.txt(managed by Dependabot), and the mod_wsgi workflows install it on demand withuv pip install -r.We cannot include
mod_wsgiin the uv lock file, since it always tries to build the wheel when resolving, even on a platform where the package is not supported.Test Plan
Patch build
Checklist
Checklist for Author
Checklist for Reviewer