Repository navigation
PYTHON-6134 Configurable DNS domain validation for SRV records: clarifications - #3084
Merged
Merged
Conversation
4 tasks done
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The implementation, documentation, and regression coverage consistently enforce the clarified behavior.
0 open findings
What changed in this PR
Clarifies SRV host validation behavior and enforces boolean validator results.
Changes:
- Rejects non-boolean
srv_host_validatorresults. - Documents polling behavior and adds regression coverage for boolean validation and underscore suffixes.
| File | Description |
|---|---|
pymongo/asynchronous/srv_resolver.py |
Enforces boolean validator results. |
pymongo/synchronous/srv_resolver.py |
Generated synchronous equivalent. |
pymongo/asynchronous/mongo_client.py |
Clarifies public API behavior. |
pymongo/synchronous/mongo_client.py |
Generated synchronous documentation equivalent. |
test/asynchronous/test_dns.py |
Adds async regression tests. |
test/test_dns.py |
Generated synchronous tests. |
doc/changelog.rst |
Documents validation semantics. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
NoahStapp
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-6134
Changes in this PR
Test Plan
Checklist
Checklist for Author
Checklist for Reviewer