Skip to content

PYTHON-6134 Configurable DNS domain validation for SRV records: clarifications - #3084

Merged
sleepyStick merged 7 commits into
mongodb:mainfrom
sleepyStick:PYTHON-6134
Oct 7, 2026
Merged

sleepyStick merged 7 commits into
mongodb:mainfrom
sleepyStick:PYTHON-6134

Conversation

@sleepyStick

Copy link
Copy Markdown
Contributor

PYTHON-6134

Changes in this PR

Test Plan

Checklist

Checklist for Author

  • Did you update the changelog (if necessary)?
  • Is there test coverage?
  • Is any followup work tracked in a JIRA ticket? If so, add link(s).

Checklist for Reviewer

  • Does the title of the PR reference a JIRA Ticket?
  • Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?)
  • Is all relevant documentation (README or docstring) updated?

@codecov

codecov Bot commented Sep 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The implementation, documentation, and regression coverage consistently enforce the clarified behavior.

0 open findings

What changed in this PR

Clarifies SRV host validation behavior and enforces boolean validator results.

Changes:

  • Rejects non-boolean srv_host_validator results.
  • Documents polling behavior and adds regression coverage for boolean validation and underscore suffixes.
File Description
pymongo/​asynchronous/​srv_resolver.py Enforces boolean validator results.
pymongo/​synchronous/​srv_resolver.py Generated synchronous equivalent.
pymongo/​asynchronous/​mongo_client.py Clarifies public API behavior.
pymongo/​synchronous/​mongo_client.py Generated synchronous documentation equivalent.
test/​asynchronous/​test_dns.py Adds async regression tests.
test/​test_dns.py Generated synchronous tests.
doc/​changelog.rst Documents validation semantics.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@sleepyStick
sleepyStick marked this pull request as ready for review October 7, 2026 17:31
@sleepyStick
sleepyStick requested a review from a team as a code owner October 7, 2026 17:31
@sleepyStick
sleepyStick requested a review from NoahStapp October 7, 2026 17:31
@sleepyStick
sleepyStick merged commit 38871d7 into mongodb:main Oct 7, 2026
92 of 94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants