Skip to content

PYTHON-6152 Remove exclude-newer handling from uv-lock-update action - #144

Merged
blink1073 merged 2 commits into
mainfrom
PYTHON-6152
Oct 15, 2026
Merged

blink1073 merged 2 commits into
mainfrom
PYTHON-6152

Conversation

@blink1073

@blink1073 blink1073 commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Summary

Removes the exclude_newer input from the python/uv-lock-update action. Each project's own uv configuration now solely decides the resolution cutoff.

Required for mongodb/mongo-python-driver#3114.

Motivation

The action injected the cutoff as an environment variable only while running the upgrade. Lock generation then ran under a different configuration than the one consumer CI uses to check the lock, so freshly updated locks read as stale (PYTHON-6151 in mongo-python-driver). The input's default also outranked the exclude-newer a repository sets in its own pyproject.toml.

Changes

  • Removed the cutoff input, so the upgrade runs with no override and the project's own uv config decides.
  • Documented in the README that a repo wanting yank protection sets exclude-newer in its own pyproject.toml or uv.toml.
  • Callers still passing the removed input get only GitHub's unexpected-input warning.

Testing

All three python/uv-lock-update/test_*.sh scripts pass, mirroring the repo's CI test job.

Breaking changes

The input is gone along with its 7-day default. A repo that relied on either must set exclude-newer in its own pyproject.toml or uv.toml before adopting the release with this change. The only known consumer, mongo-python-driver, already sets it and drops its override in PYTHON-6153.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused implementation and documentation consistently remove the action-level override without leaving stale references.

0 open findings

What changed in this PR

Removes the action-level uv resolution cutoff so repositories control dependency age policy through their own uv configuration.

Changes:

  • Removes the exclude_newer input and UV_EXCLUDE_NEWER override.
  • Documents repository-level exclude-newer configuration.
File Description
python/​uv-lock-update/​action.yml Removes cutoff input and environment handling.
python/​README.md Documents project-owned cutoff configuration.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@blink1073
blink1073 marked this pull request as ready for review October 9, 2026 23:00
@blink1073
blink1073 requested a review from a team as a code owner October 9, 2026 23:00
@blink1073
blink1073 requested a review from GromNaN October 9, 2026 23:00
Comment thread python/uv-lock-update/action.yml
@blink1073
blink1073 requested a review from GromNaN October 14, 2026 21:09
@blink1073
blink1073 merged commit 99b1cbd into main Oct 15, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants