Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/check-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,12 @@ jobs:
git checkout -- packages/saslprep/src/code-points-data.ts
shell: bash

- name: Configure Electron sandbox
if: ${{ runner.os == 'Linux' }}
run: |
sudo chown root:root node_modules/electron/dist/chrome-sandbox
sudo chmod 4755 node_modules/electron/dist/chrome-sandbox

- name: Info
run: |
LERNA_VERSION=$(npm ls lerna --json | jq -r .dependencies.lerna.version)
Expand Down
2 changes: 1 addition & 1 deletion packages/devtools-proxy-support/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"check": "npm run typecheck && npm run lint && npm run depcheck",
"check-ci": "npm run check",
"test": "mocha",
"test-cov": "nyc -x \"**/*.spec.*\" --reporter=lcov --reporter=text --reporter=html npm run test",
"test-cov": "nyc --use-spawn-wrap -x \"**/*.spec.*\" --reporter=lcov --reporter=text --reporter=html npm run test",
"test-watch": "npm run test -- --watch",
"test-ci": "npm run test-cov",
"reformat": "npm run prettier -- --write ."
Expand Down
16 changes: 6 additions & 10 deletions packages/devtools-proxy-support/src/proxy-options.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -172,14 +172,6 @@ describe('proxy options handling', function () {
let setup: HTTPServerProxyTestSetup;

before(async function () {
// TODO: COMPASS-9232 reenable the test on Linux and, ideally, on Windows, after
// investigating the failures.
if (
(process.platform === 'win32' || process.platform === 'linux') &&
process.env.CI
) {
return this.skip();
}
setup = new HTTPServerProxyTestSetup();
await setup.listen();

Expand All @@ -190,9 +182,13 @@ describe('proxy options handling', function () {
await once(server, 'listening');
const connEvent = once(server, 'connection');
childProcess = spawn(
'npx',
// Resolving the xvfb-maybe script and running it with the current
// Node binary rather than going through `npx`, because on Windows
// spawning `npx` (really `npx.cmd`) fails with ENOENT unless a shell
// is used.
process.execPath,
[
'xvfb-maybe',
require.resolve('xvfb-maybe/src/xvfb-maybe.js'),
// eslint-disable-next-line @typescript-eslint/no-var-requires
require('electron') as unknown as string,
path.resolve(__dirname, '..', 'test', 'electron-test-server.js'),
Expand Down
Loading