Repository navigation
feat(mongodb-runner): add --json output to start and ls - #923
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
JSON output and serialization have unresolved correctness and credential-exposure issues.
3 open findings
What changed in this PR
Adds machine-readable output to mongodb-runner for CLI automation.
Changes:
- Adds
--jsonoutput forstartandls. - Exports serialization types and records cluster options and server commands.
- Adds JSON-output tests and documentation.
| File | Description |
|---|---|
| packages/mongodb-runner/src/runner-helpers.ts | Types stored cluster metadata. |
| packages/mongodb-runner/src/mongoserver.ts | Preserves server command lines. |
| packages/mongodb-runner/src/mongocluster.ts | Types serialization and preserves options. |
| packages/mongodb-runner/src/index.ts | Exports serialization types. |
| packages/mongodb-runner/src/cli.ts | Implements JSON output. |
| packages/mongodb-runner/src/cli.spec.ts | Tests structured output. |
| packages/mongodb-runner/README.md | Documents JSON usage and formats. |
| packages/mongodb-runner/docs/disaggregated-storage.md | Documents structured SLS output. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
autarch
force-pushed
the
mongodb-runner-json-output
branch
from
October 7, 2026 19:36
58a5e35 to
7fcdd00
Compare
autarch
marked this pull request as ready for review
October 7, 2026 19:39
Collaborator
Author
|
This takes the changes in #626 and adds some additional SLS-specific output on top of that. |
autarch
force-pushed
the
mongodb-runner-json-output
branch
from
October 7, 2026 20:25
7fcdd00 to
57833ca
Compare
addaleax
approved these changes
Oct 8, 2026
nbbeeken
requested changes
Oct 8, 2026
nbbeeken
left a comment
nbbeeken
left a comment
Collaborator
There was a problem hiding this comment.
mostly questions, I think the one-line idea is worth consideration
start --json prints a JSON object with the cluster id and connection string (plus OIDC and SLS details when applicable) instead of the bare connection string. ls --json prints a JSON array of the running instances, including their serialized cluster data with credentials redacted. Both print single-line JSON for easier parsing in shell scripts.
autarch
force-pushed
the
mongodb-runner-json-output
branch
from
October 8, 2026 15:42
57833ca to
4e179da
Compare
nbbeeken
approved these changes
Oct 8, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.