Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes image update checks use
instead of
Results are identical, but as explained in linked issue, it uses significantly less quota, measured with at least Docker Hub.
Note that the
Cargo.lockdiff here showsurlencodingandformattingwere removed. Those were not a manually-changed part of this PR, but it happened automatically, presumably because some earlier change didn't properly re-generate / commit that change.Tested via a local dev instance, which showed checks still working, and using less quota (as evidenced via the Docker Hub apis mentioned in the linked issue).
Resolves #1652