refactor(vueManager): parallelize option field values load in OrderView#447
Open
Ibochkarev wants to merge 1 commit into
Open
refactor(vueManager): parallelize option field values load in OrderView#447Ibochkarev wants to merge 1 commit into
Ibochkarev wants to merge 1 commit into
Conversation
Replace sequential await in initOptionsFromProduct loop with Promise.all to reduce UI latency when editing order products with many option fields. Closes #359
Ibochkarev
changed the title
Ibochkarev
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
В
initOptionsFromProductзагрузка значений product option fields выполнялась последовательно: N полей давали N последовательных запросов к/api/mgr/references/product-field-values. Теперь строки сначала собираются вfieldRowsToLoad, затем значения подгружаются параллельно черезPromise.all.Тип изменений
Связанные Issues
Closes #359
Как это было протестировано?
Локальный гейт:
npm run lint:ci/ GitHub Actions CI)Конфигурация тестирования:
feat/issue-359-promise-all-field-valuesСкриншоты (если применимо)
Чеклист
npx eslint src/components/OrderView.vue)Дополнительные заметки
loadFieldValuesForRowпо-прежнему обрабатывает ошибки внутри; один неудачный запрос не прерывает остальные.optionsTableDataприсваивается после завершения всех загрузок — порядок строк в таблице сохранён.loadFieldValuesForRowвonOptionTypeChange/onFieldKeyChangeне менялись (не batch-сценарий).