fix(mgr): scope category product publish/bulk by parent#443
Open
Ibochkarev wants to merge 2 commits into
Open
Conversation
Prevent IDOR where publish/multiple/bulkDelete could mutate products outside the category from the URL by requiring parent = categoryId, matching the existing sort() contract.
Ibochkarev
added
priority: high
- CategoryTreeService + nested param for publish/multiple/sort scope - Vue grid passes nested flag to mutation requests - Category routes: array_merge($data, $params) so URL id wins - Smoke tests for tree, nested scope, sort happy path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Закрывает IDOR в Manager API «Товары категории»:
publish,multipleиbulkDeleteзагружали товар только поid, без проверкиparent = categoryIdиз URL. Теперь все мутации (включая уже корректныйsort) идут черезCategoryProductScopeService::findInCategory().Тип изменений
Связанные Issues
Closes #418
Как это было протестировано?
Локальный CI-гейт (без MODX/MySQL):
composer ci:php)Конфигурация тестирования:
Чеклист
Дополнительные заметки
sort(): только прямые дочерние товары (parent = categoryId). В nested-режиме списка (nested=1) мутации по URL родительской категории для товаров из подкатегорий по-прежнему не проходят — это согласовано с drag-sort (canDragотключён). Расширение scope под nested — отдельная задача, если понадобится.