feat(ci): PHPStan gate + PHPUnit scaffold for pure helpers#433
Open
Ibochkarev wants to merge 4 commits into
Open
feat(ci): PHPStan gate + PHPUnit scaffold for pure helpers#433Ibochkarev wants to merge 4 commits into
Ibochkarev wants to merge 4 commits into
Conversation
Ibochkarev
force-pushed
the
feat/issue-429-phpstan-ci
branch
from
July 23, 2026 16:08
596d958 to
75bd1ca
Compare
Wire level-0 static analysis into CI so PR reviews stop relying on manual PHPStan runs; pin MODX/pdoTools trees and keep historical findings in baseline so only new errors fail the gate.
Level 1 of the testing roadmap: PHPUnit in CI beside smoke, migrate CSV option parse and email-verify URL cases, cover charset helpers plus security allowlists; extract Phinx charset helpers for F.I.R.S.T. tests.
Renaming the check broke the beta required status "PHP lint + smoke", so the PR stayed blocked waiting for a check that never runs.
Bump checkout/setup-node/cache to v5 (Node 24 action runtime) and run vueManager lint on Node 24 so CI stops requesting the EOL Node 20 toolchain.
Ibochkarev
force-pushed
the
feat/issue-429-phpstan-ci
branch
from
July 24, 2026 02:16
75bd1ca to
4ce69b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Roadmap #429, уровни 0–1 в одном PR:
composer stan/ jobPHPStan), portablephpstan.neon, baseline, pinned MODX/pdoTools.tests/Unit/,composer testвнутриci:php. Перенесены кейсы CSV option parse и email-verify URL; добавлены charset helpers,OptionColumnSpec,GridEditorReferenceRegistry. Хелперы charset вынесены вphinx_mysql_charset.php.Тип изменений
Связанные Issues
Closes #395
Refs #429 (уровни 0–1; интеграционные тесты и Vitest — follow-up)
Как это было протестировано?
Локально (exit 0):
composer ci:php,composer test,composer stan/ GitHub Actions CI)Конфигурация тестирования:
feat/issue-429-phpstan-ciscripts/phpstan-deps.pinsСкриншоты (если применимо)
Чеклист
composer stan/ CI jobPHPStan)npm run lint:ciдля Vue)Дополнительные заметки
ms3PhinxExtractDsnCharsetпринимает иmysql:charset=…(PDO).PHPStan.