Skip to content

sdg(phase-11): fix the first-release no-op version bump in the Release workflow #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lzrscg merged 1 commit into from
Jul 28, 2026
Merged

sdg(phase-11): fix the first-release no-op version bump in the Release workflow #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,10 @@ jobs:
else
echo "No NPM_TOKEN secret — publishing via the OIDC trusted-publishing exchange."
fi
npm version "${{ steps.version.outputs.next }}" --no-git-tag-version
if ! npm publish --provenance --access public; then
# --allow-same-version: a first release publishes package.json's own
# version, so the bump is a no-op that plain `npm version` rejects.
if ! { npm version "${{ steps.version.outputs.next }}" --no-git-tag-version --allow-same-version &&
npm publish --provenance --access public; }; then
echo "::error::Publishing @modularcloud/xspec@${{ steps.version.outputs.next }} failed, so this green main commit was NOT released — see the npm error above. If it is an auth error (E401/E403/E404/ENEEDAUTH), the one-time npm-side setup (specs/DEVOPS.md — npm releases, Credentials) is incomplete: configure the package's Trusted Publisher on npmjs.com (GitHub Actions: owner modularcloud, repository xspec, workflow release.yml) — or, for bootstrap only, set the NPM_TOKEN repository secret. Then re-run this workflow run: it publishes exactly this commit, and duplicate attempts are safe because the registry refuses to republish an existing version."
exit 1
fi
Expand Down
Loading