Repository navigation
fix(app): only load the Java agent on versions that need injected Quick Play - #8333
seiftnesse wants to merge 1 commit into
Conversation
Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
|
This pull request is closed, so it cannot be queued. Reopen it to get the box back. |
|
hi there, @IMB11 code/packages/app-lib/src/launcher/args.rs Lines 164 to 172 in 1b27f67 |
|
@seiftnesse here's the explanation #7300 (comment), a similar PR was already made for this & rejected. tldr; the java agent will be used for more than just quick play within the future, so it doesn't make sense to add additional logic only for them to remove it later. (it's worth noting that i'm not apart of the modrinth team, so take this with a grain of salt) |
i hadn’t seen that report before, thanks for linking it. after reading it, i think we’re running into a similar compatibility issue. their protection blocks any java agent, while ours allows the agent and only flags an active |
|
why are you doing that? |
the launcher currently passes
-javaagenton every minecraft launch. this registers a class file transformer even on versions where it has no patch to apply, which can trigger false positives in tools that monitor JVM instrumentation.only pass
-javaagentwhen the minecraft version usesQuickPlayServerVersion::Injected, the launcher still putstheseus.jaron the classpath for its launch wrapper and IPC.