Skip to content

fix: prefer iconFile over logoFile for neoforge mod icons - #8328

Merged
IMB11 merged 1 commit into
modrinth:mainfrom
creeperkatze:neoforge-mod-icon
Nov 14, 2026
Merged

IMB11 merged 1 commit into
modrinth:mainfrom
creeperkatze:neoforge-mod-icon

Conversation

@creeperkatze

Copy link
Copy Markdown
Contributor

Fixes local NeoForge mods showing their banner instead of their icon in the instance content list, for jars that aren't on Modrinth.

NeoForge uses iconFile for the square mod icon and logoFile for a wide banner shown in its mod list. The parser now reads iconFile first and falls back to logoFile, so Forge mods and NeoForge mods without an iconFile show the same icon as before.

@github-actions

Copy link
Copy Markdown
Contributor

Pull request changelog

App

Added

Changed

Deprecated

Removed

Fixed

Security

Website

Added

Changed

Deprecated

Removed

Fixed

Security

Hosting

Added

Changed

Deprecated

Removed

Fixed

Security

@mergify

mergify Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

This pull request is merged.

@IMB11
IMB11 merged commit 1b27f67 into modrinth:main Nov 14, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants