Repository navigation
Conversation
Contributor
Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
|
This pull request is closed, so it cannot be queued. Reopen it to get the box back. |
Member
|
Do not open slop PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8326
What
Installing from an invite link calls
accept_shared_instance_invite_for_install, which probes access first and only accepts the invite when the probe answers 401. If the probe answers 403, the unmapped status becomes an error before the accept is attempted (the toast then showsHTTP 403). If the probe answers successfully, that is treated as membership and the accept is skipped, so the membership-only version listing fails afterwards.This accepts the invite first and falls back to the access probe only when the accept call fails. Accepting is idempotent on the client side - an "already has access" response is already treated as success - so reinstalls and owner installs keep working.
It also lines this path up with the notification path, which already accepts first (
accept_pending_shared_instance_invite).Testing
I could not test this end to end against the shared instances service from here. Repro to check with an invite whose recipient is still pending:
HTTP 403Happy to adjust if the membership check is supposed to happen somewhere else.
Confirmed failure point
The affected installation logs:
That is the access probe, before any accept attempt. 403 is not mapped by
SharedInstanceUnavailableReason::from_status, so the?aborts andaccept_shared_instance_inviteis never reached. Accepting first removes that abort path entirely.