Repository navigation
Conversation
Contributor
Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
|
This pull request is closed, so it cannot be queued. Reopen it to get the box back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(app): bound memory and entry count when extracting zips
What
file_extract_zipinapps/app/src/api/files.rsreads each archive entry into aVec<u8>withread_to_endand has no limits on entry size, total extracted size orentry count, so a crafted archive can exhaust memory or disk when a user extracts it.
Change
Before extracting:
Per entry:
take(limit + 1)and re-check the actual length, so an entry whosecentral directory size disagrees with its contents cannot exceed the budget.
Path handling is unchanged.
validate_instance_file_writealready resolves eachtarget and keeps writes inside the instance directory, so this is only about
resource use.
Notes for reviewers
They are generous for normal packs and easy to tune.
compressed file size is bounded upstream; this bounds the expansion.
Testing
cargo clippy -p theseus -p theseus_gui --all-targetsfail with the new error instead of allocating.
writing anything.