Skip to content

perf: speed up playtime and download count analytics queries - #8318

Merged
clrxbl merged 2 commits into
mainfrom
fix/slow-analytics
Nov 13, 2026
Merged

clrxbl merged 2 commits into
mainfrom
fix/slow-analytics

Conversation

@clrxbl

@clrxbl clrxbl commented Nov 13, 2026

Copy link
Copy Markdown
Member

No description provided.

Add a by_parent projection on playtime so modpack playtime lookups no
longer scan the whole time window. Split the dashboard's 9-dimension
download count request into per-field requests, which also stops small
cross-product buckets from collapsing countries into XX.
@github-actions

Copy link
Copy Markdown
Contributor

Pull request changelog

App

Added

Changed

Deprecated

Removed

Fixed

Security

Website

Added

Changed

Deprecated

Removed

Fixed

Security

Hosting

Added

Changed

Deprecated

Removed

Fixed

Security

@mergify

mergify Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Queue requested — the merge queue status continues in this comment ↓.

@greptile-apps

greptile-apps Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

[Medium impact] The changes stay within analytics dashboard counts and modpack playtime queries.

The PR appears safe to merge, with a non-blocking improvement to keep successful download counts when another request fails.

Summary

This PR reduces the fields used to group download counts and adds a ClickHouse projection for parent-based playtime queries.

  • Download filter totals come from focused breakdown queries.
  • Modpack playtime lookups can use a parent-ordered projection.

Reviews (1) · Last reviewed commit: "perf: speed up playtime and download cou..." · Reviewed by Greptile

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Frontend previews

Last deployed commit is c7c9d75c9607c466bc114c58a3b85753d3ff55de

Persistent

Environment URL
staging https://pr-8318.frontend-staging.rinth.dev
production https://pr-8318.frontend.rinth.dev
storybook https://pr-8318-storybook.modrinth.workers.dev

Latest commit

Environment URL
staging https://86baa917.frontend-staging.rinth.dev
production https://d75028a1.frontend.rinth.dev

Use a separate query for each download count breakdown so one failed
request no longer hides the other counts, and each keeps its own retry.
@mergify

mergify Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

🛑 Queue command cancelled

Tick the box to add this pull request to the merge queue (same as @mergifyio queue). If it does not match the queue conditions yet, it enters the queue once it does.

  • Queue this pull request

@clrxbl

clrxbl commented Nov 13, 2026

Copy link
Copy Markdown
Member Author

@Mergifyio dequeue

@clrxbl
clrxbl merged commit 46211a1 into main Nov 13, 2026
15 checks passed
@clrxbl
clrxbl deleted the fix/slow-analytics branch November 13, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant