Skip to content

Change session auth to pass around one-time redeemable tokens rather than session tokens - #8217

Merged
Prospector merged 3 commits into
mainfrom
prospector/new-auth-passing-method
Nov 13, 2026
Merged

Prospector merged 3 commits into
mainfrom
prospector/new-auth-passing-method

Conversation

@Prospector

Copy link
Copy Markdown
Member

No description provided.

@Prospector
Prospector added this pull request to stack #8218 November 3, 2026 20:55
@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Note

This changelog has been merged into the changelog for #8142

Pull request changelog

App

Added

Changed

Deprecated

Removed

Fixed

Security

Website

Added

Changed

Deprecated

Removed

Fixed

Security

Hosting

Added

Changed

Deprecated

Removed

Fixed

Security

@greptile-apps

greptile-apps Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Critical impact] The PR appears safe to merge, with no outstanding findings.

Summary

Replaces session tokens in OAuth callback URLs with short-lived, single-use codes tied to the browser’s PKCE verifier.

  • OAuth callbacks return short-lived codes instead of sessions.
  • OAuth pages keep a verifier and exchange the returned code.
  • Search indexing keeps its metadata type explicit.

Reviews (4) · Last reviewed commit: "fix whitespace" · Reviewed by Greptile

@Prospector
Prospector requested a review from a team November 4, 2026 19:14
@mergify

mergify Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Queue requested — the merge queue status continues in this comment ↓.

Base automatically changed from prospector/auth-modal to main November 10, 2026 20:42
@Prospector
Prospector force-pushed the prospector/new-auth-passing-method branch from 98495bb to c9fcb8b Compare November 10, 2026 20:42
@Prospector

Copy link
Copy Markdown
Member Author

@Mergifyio queue

@mergify

mergify Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

🛑 Queue command cancelled

Tick the box to add this pull request to the merge queue (same as @mergifyio queue). If it does not match the queue conditions yet, it enters the queue once it does.

  • Queue this pull request

@Prospector
Prospector force-pushed the prospector/new-auth-passing-method branch from 6a9ec55 to dd85bce Compare November 13, 2026 16:47
@mergify

mergify Bot commented Nov 13, 2026

Copy link
Copy Markdown

queue

🛑 The queue request has been cancelled: new commits were pushed

Details

@Prospector pushed to this pull request after queue was requested. Review the new commits and request it again.

@github-actions

Copy link
Copy Markdown
Contributor

Frontend previews

Last deployed commit is dd85bce77e5b2578410b9fc046a1360fd35cf450

Persistent

Environment URL
staging https://pr-8217.frontend-staging.rinth.dev
production https://pr-8217.frontend.rinth.dev
storybook https://pr-8217-storybook.modrinth.workers.dev

Latest commit

Environment URL
staging https://d6893d9b.frontend-staging.rinth.dev
production https://32308db8.frontend.rinth.dev

@Prospector
Prospector force-pushed the prospector/new-auth-passing-method branch from dd85bce to 995e74d Compare November 13, 2026 17:10
@Prospector
Prospector merged commit 25a9a03 into main Nov 13, 2026
4 of 9 checks passed
@Prospector
Prospector deleted the prospector/new-auth-passing-method branch November 13, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants