Skip to content

Line up service rows and give the side column 40% - #47

Merged
lesnik512 merged 1 commit into
mainfrom
align-service-rows
Oct 20, 2026
Merged

lesnik512 merged 1 commit into
mainfrom
align-service-rows

Conversation

@lesnik512

@lesnik512 lesnik512 commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

Service rows on the page didn't line up. Everything after the tag slot moved depending on whether a service had a picked tag (the 1.9.0 × chip) or the "pick a tag" hint, and on how long the production version was. The fully deployed row also sat 3px to the right because of its 4px left border.

Changes:

  • The production version and the tag slot get an 8rem minimum width. A picked and an unpicked row now place the untagged warning and the counts at the same x. 8rem fits "not in production" and an 8-character SHA. A longer tag or service name still pushes its own row out; that case is left alone here.
  • The deployed row keeps a 1px border and draws its green stripe as an inset shadow, so its contents start where the other rows' do.
  • The side column now takes 2 of 5 parts of the layout (3fr 2fr) with a 420px floor, in place of clamp(420px, 32vw, 640px). At 1920px it is about 746px wide; in windows narrower than about 1100px the 420px floor applies.

Tests: test_demo_service_rows_line_up_with_and_without_a_pick checks the x positions across the admin, api, web and worker rows with a pick on web. The side column width test now expects 40% of the layout. Both failed before the change. just test, just test-smoke and just lint pass.

@lesnik512
lesnik512 merged commit 4260d37 into main Oct 20, 2026
13 checks passed
@lesnik512
lesnik512 deleted the align-service-rows branch October 20, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant