Repository navigation
Line up service rows and give the side column 40% - #47
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Service rows on the page didn't line up. Everything after the tag slot moved depending on whether a service had a picked tag (the
1.9.0 ×chip) or the "pick a tag" hint, and on how long the production version was. The fully deployed row also sat 3px to the right because of its 4px left border.Changes:
3fr 2fr) with a 420px floor, in place ofclamp(420px, 32vw, 640px). At 1920px it is about 746px wide; in windows narrower than about 1100px the 420px floor applies.Tests:
test_demo_service_rows_line_up_with_and_without_a_pickchecks the x positions across the admin, api, web and worker rows with a pick on web. The side column width test now expects 40% of the layout. Both failed before the change.just test,just test-smokeandjust lintpass.