Repository navigation
fix: leave updates of an unknown type to aiogram - #59
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
setup_di, an update whose type aiogram does not know raisedUpdateTypeLookupErrorout offeed_update. Without DI, aiogram warns "Detected unknown update type" and returnsUNHANDLED(Dispatcher._listen_update). The DI middleware wraps the dispatcher's update handling and readupdate.eventto fill the child container's context, so it raised before aiogram's handler ever got to its own check.This happens whenever Telegram adds an update type the installed aiogram does not know yet. Under polling, each such update logged an error traceback. Under a webhook with
handle_in_background=False,feed_webhook_updatere-raised, so Telegram got an error response and redelivered the update.Updatestill always goes into the child's context.TelegramObjectis now added only whenupdate.eventresolves, so for an unknown type the middleware passes the update on and aiogram warns and returnsUNHANDLEDas it does without DI.The new test feeds
Update(update_id=1)and expects aiogram's warning andUNHANDLED. On main it fails withUpdateTypeLookupError.