docs(planning): file the double-bootstrap guard change - #165
Merged
Conversation
A second bootstrapper on the same application skips only the teardown attach: Litestar then dies with a duplicate-route error from inside the framework and FastAPI silently registers a second copy of its health and metrics routes. Both reproduced; the design makes bootstrap() raise instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One proposal, no code. Found while reviewing #164.
_attach_teardown_onceguards teardown attachment and nothing else, so a second bootstrapper constructed on the same application still applies every instrument whenbootstrap()is called. Both halves reproduced on current main:ImproperlyConfiguredException: Handler already registered for path '/health' and http method OPTIONS— which points nowhere near the real mistake.bootstrap()returns the same app with its route count grown from 6 to 8, a shadowed duplicate of the health and metrics routes plus a second set of instrument state whose teardown is wired to nothing.planning/changes/2026-08-10.04-double-bootstrap-guard.mdproposes makingbootstrap()raiseConfigurationErroron the bootstrapper whose attach was skipped. The construction-time warning stays, so the documented warn-and-skip invariant for the teardown seam is unchanged.just check-planningandjust lint-cipass.🤖 Generated with Claude Code