feat: require --yes confirmation for destructive operations - #183
Merged
Conversation
- finetune/deploy/dataset delete: add --yes flag + confirmDangerousAction - quota update --delete: confirm before clearing rate limits - non-TTY runs without --yes fail with a USAGE error - add e2e coverage and regenerate skill references
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--yes+confirmDangerousActionhigh-risk confirmation guard to the destructive commands:finetune delete,deploy delete,dataset delete, andquota update --delete--yesnow exits with USAGE(2) and points to--yes; the confirmation gate runs after--dry-runand before any network call (fordeploy delete, after the status precheck)quota updateonly triggers confirmation on the--deletepath; regular--rpm/--tpmupdates are unaffectedTest plan
--helpshows--yes, and non-TTY runs without--yesexit with code 2 for all four commandsvp checkpasses (0 errors)pnpm run sync:skill-assetsare committed