Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With
agent_stream_file: true,LLMAgent.step()yields cumulative histories while the final assistant message is still growing.SubAgentStreamWriterpreviously marked that message written after the first chunk, so the trace advertised to the parent agent permanently retained only the first token (and incomplete tool-call arguments), even when the sub-agent completed successfully.The trace remains append-only and message-granular: a growing final message is now emitted when completed rather than emitting its first token as if complete.
Validation
Hinstead ofHello).test_stream_writer.py,test_task_manager_smoke.py,test_partial_round.py,test_llm_io.py): 64 passed, 15 skipped, 1 pre-existing failure.TestAgentToolTranscript::test_save_transcript_writes_message_objects_and_dictsstill expectssubagents/worker-1.jsonlinstead of the current.ms_agent/subagents/worker-1.jsonl; reproduced unchanged on the base commit.git diff --check: passed.AI assistance
Implementation and automated verification were performed with OpenAI Codex. No claim of human review is made.