Repository navigation
Conversation
timestamp_sentence inserts a space before an English word but, unlike timestamp_sentence_en, never removes a leading space. A Chinese utterance that continues in English was stored as " iphone pro max.". Signed-off-by: Ting Zhang <181050363+GPT-AGI@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
LauraGPT
reviewed
Nov 10, 2026
LauraGPT
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed exact head 245ee66ac8faa3413c2d03a964c91718c93cdc15 against its original base 20f26b7c4905d010768ec91206149df2a90104b6.
- Baseline with the new regression fails on the synthetic leading space (
' iphone pro max。'). - Exact head: 9/9 timestamp-tool tests pass, covering Latin sentence starts, mixed Chinese/Latin text, all-English/all-Chinese controls, raw text, punctuation, and boundaries.
No exact-head hosted check currently covers this PR, and main has advanced since the tested base. Leaving it open pending current-base revalidation plus hosted coverage. Scope is deterministic CPU text/timestamp postprocessing only; no model, GPU, ASR-quality, or release claim.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Input:
timestamp_sentenceinserts a separator before each Latin token, including thefirst token of a sentence. Drop that one leading separator using the same check
as
timestamp_sentence_en; internal English spaces remain unchanged.Type of change
Validation
python -m pytest -q tests/test_timestamp_tools.py— 9 passedpython -m compileall -q funasr examples testsUser impact
sentence_infotext no longer starts with a synthetic space when a sentencestarts with a Latin word.
Notes for reviewers
Four before/after controls covered a Latin-starting sentence, Latin text within
Chinese, all-English, and all-Chinese input. Sentence boundaries, timestamps,
punctuation, and
raw_textwere unchanged.