Repository navigation
fix(normalize): correct variance with reproducible CPU/CUDA regressions - #3856
Merged
Merged
Conversation
Preserve the original PR #3853 commit. Synchronize retained main content to the exact tested integration tree without rewriting history. Use IEEE FP32 only inside audio integration tests, restore backend settings, and keep all assertions and tolerances unchanged. Add the regression file to the existing NumPy matrix. Signed-off-by: LauraGPT <zhifu.gzf@alibaba-inc.com>
Resolve the confirmed companion/main conflict by retaining the accepted tokenizer changes and both CI selections. All 58 combined CPU/CUDA regressions passed on the exact combined source. No history rewrite or protection bypass. Signed-off-by: LauraGPT <zhifu.gzf@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integrates #3853 while preserving the original contributor commit and authorship. The appended signed commit synchronizes retained main content to the exact tested integration tree without rewriting history. UtteranceMVN's both-enabled branch excludes centered padding from variance and divides by standard deviation once. Other normalization branches retain their existing behavior.
Adds the submitted regression file to NumPy CI. The audio integration test now explicitly uses IEEE FP32 rather than environment-dependent TF32, restoring both backend settings afterward. AST comparison verifies every original assertion, tolerance, reference and test body is unchanged.
Maintainer validation
Compatibility
Both norm_means=True and norm_vars=True now produce corrected feature values. Existing checkpoints trained with both enabled require recognition-quality reevaluation. norm_vars defaults to False; this PR does not claim pretrained quality is unchanged. No release, Nano work or production modification is included.