Repository navigation
fix(tokenizer): prevent empty-symbol hangs with hosted regression coverage - #3855
Merged
Merged
Conversation
CharTokenizer and PhonemeTokenizer load non_linguistic_symbols with
line.rstrip(), so a blank line in the symbol file (or an "" entry in a
list) adds the empty string to the set. line.startswith("") is true at
every position without consuming any input, so text2tokens never
terminates (and keeps appending "" tokens when symbols are kept).
Drop the empty string after the symbols are loaded and add a regression
test covering a file with a blank line and an iterable with "".
Preserve the original PR #3852 commit and add only missing trigger paths and regression selection. Signed-off-by: LauraGPT <zhifu.gzf@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integrates #3852 while preserving its original commit and authorship. Adds only missing NumPy workflow paths and the submitted regression file to hosted CI. The original PR triggered no workflows; this companion makes the regression enforceable before normal merge.
Empty non-linguistic symbols from a blank line or iterable no longer trap CharTokenizer/PhonemeTokenizer in a non-consuming loop. Nonempty symbol behavior is retained.
Maintainer validation
This is not a new release. Nano and production services are unchanged.