Repository navigation
fix(examples): avoid smoke-test collection name collisions - #3812
Merged
Merged
Conversation
Namespace both standalone smoke CLIs without renaming commands or hiding tests. Signed-off-by: LauraGPT <zhifu.gzf@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add package markers to the MCP and OpenAI API example directories so their
standalone
smoke_test.pyscripts have distinct import names under pytest.Both documented CLI paths remain unchanged. No model, inference, Docker
publication policy, pytest discovery setting or exclusion is changed.
Add a real subprocess regression for prepend, append and importlib collection,
plus both direct
--helpinvocations. A small path-filtered, read-only CI jobruns this and the existing example metadata contracts on Python 3.10 and 3.12,
retaining exact source-commit, dependency and JUnit evidence.
Validation
controls (importlib and both standalone help commands).
discovery command passes 21 cases. No live service/model/provider call.
python -m pytest -qwas attempted, not silently narrowed. Theexample name collision is gone. Four pre-existing collection errors remain:
runtime/python/utils/test_cer.py,test_rtf.py,test_rtf_gpu.pyparsemandatory CLI arguments on import; the separate
funasr_onnxdependency ismissing for
tests/test_funasr_onnx_paraformer_online_empty_final.py.Two existing optional skips remain. This is NOT a passing full-suite claim.
No GPU/runtime change, pretrained ASR quality result, Nano work, release or
PyPI upload is implied. Actual code review is by the maintainer implementing
this fix, not claimed as an independent GitHub review.
No administrator bypass, self approval or protection change.