fix(client): follow repeated opaque cursors - #2736
Open
mikemikimike wants to merge 3 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 16a3e17 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2735
Background
The automatic list pagination path treated repeated cursor values as a reason to stop. MCP cursors are opaque, so a conforming server may return the same cursor for multiple pages. Stopping on repetition silently returned an incomplete list.
Changes
Client._listAllPages.nextCursor.listMaxPageshard cap so non-terminating pagination still fails withListPaginationExceeded.@modelcontextprotocol/client.Compatibility
This preserves the public pagination API and follows opaque cursor semantics. Servers that do not terminate pagination remain bounded by
listMaxPages; only the prior silent truncation behavior changes.Verification
pnpm install --frozen-lockfile— blocked by WindowsEPERMwhile copying files from the pnpm store intonode_modules.pnpm install --frozen-lockfile --force— same WindowsEPERMduring dependency installation.pnpm test:allandpnpm lint:allcould not run because the locked dependency installation did not complete.git diff --check— passed.The focused Vitest and typecheck commands remain to be run in CI or another environment where the locked workspace dependencies can be installed.