Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/decode-uri-template-matches.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@modelcontextprotocol/core-internal': patch
---

Decode percent-encoded values returned by URI template matching while preserving malformed encodings.
12 changes: 11 additions & 1 deletion packages/core-internal/src/shared/uriTemplate.ts
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,15 @@ export class UriTemplate {
return str.replaceAll(/[.*+?^${}()|[\]\\]/g, String.raw`\$&`);
}

private decodeValue(value: string): string {
try {
return decodeURIComponent(value);
} catch {
// Preserve malformed percent-encoded values rather than making URI matching throw.
return value;
}
}

private partToRegExp(part: {
name: string;
operator: string;
Expand Down Expand Up @@ -282,7 +291,8 @@ export class UriTemplate {
const value = match[i + 1]!;
const cleanName = name.replace('*', '');

result[cleanName] = exploded && value.includes(',') ? value.split(',') : value;
result[cleanName] =
exploded && value.includes(',') ? value.split(',').map(value => this.decodeValue(value)) : this.decodeValue(value);
}

return result;
Expand Down
17 changes: 17 additions & 0 deletions packages/core-internal/test/shared/uriTemplate.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,23 @@ describe('UriTemplate', () => {
const match = template.match('/red,green,blue');
expect(match).toEqual({ list: ['red', 'green', 'blue'] });
});

it('should percent-decode matched values', () => {
const template = new UriTemplate('/users/{username}{?query}{/tags*}');
const match = template.match('/users/Ada%20Lovelace?query=machine%20learning/r%26d,AI%2FML');

expect(match).toEqual({
username: 'Ada Lovelace',
query: 'machine learning',
tags: ['r&d', 'AI/ML']
});
});

it('should preserve malformed percent-encoded values', () => {
const template = new UriTemplate('/users/{username}');

expect(template.match('/users/Ada%ZZ')).toEqual({ username: 'Ada%ZZ' });
});
});

describe('edge cases', () => {
Expand Down
Loading