fix(client): surface underlying network error via Error.cause on probe failures (#2657) - #2726
Open
LuckTerence wants to merge 4 commits into
Open
fix(client): surface underlying network error via Error.cause on probe failures (#2657)#2726LuckTerence wants to merge 4 commits into
LuckTerence wants to merge 4 commits into
Conversation
🦋 Changeset detectedLatest commit: 73f81d9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
The probeAuthSeam control test reads the underlying network error via SdkError.data.cause; passing it only as ErrorOptions left data undefined and crashed the suite. Populate both slots so the legacy data.cause contract and the standard Error.cause chain (modelcontextprotocol#2657) both hold.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2657
Bug
classifyNetworkErrorpassed{ cause: error }as the third constructor argument ofSdkError— thedataslot. The underlyingTypeError: fetch failed(and the DNS error beneath it) therefore never reached the standardError.causechain: anything walking.causestops at theSdkErrorwithcause === undefined.Changes
packages/core-internal/src/errors/sdkErrors.ts:SdkErrornow accepts an optionalErrorOptionsfourth argument and forwards it tosuper(standard ES error-causing; backward compatible —datastays the third parameter andSdkHttpErroris untouched)packages/client/src/client/probeClassifier.ts:classifyNetworkErrornow passes the underlying error via{ cause }options instead of the data slotprobeClassifier.test.ts: asserts the verdict'serror.causeis the original network errorVerification
packages/client:vitest run test/client/probeClassifier.test.ts→ 36/36 passedpackages/core-internal: full suite → 69 files / 1447 tests passed