Unify git_log output format between filtered and unfiltered paths - #4681
Open
sachinsharma3191 wants to merge 1 commit into
Open
Unify git_log output format between filtered and unfiltered paths#4681sachinsharma3191 wants to merge 1 commit into
sachinsharma3191 wants to merge 1 commit into
Conversation
…ered calls The filtered branch (with start/end timestamps) used raw git log --format with %s (subject only), while the unfiltered branch used Python repr (!r) formatting on commit fields. This produced inconsistent output schemas: - Filtered: raw hash, author name only, subject only - Unfiltered: quoted hash, git.Actor repr, quoted message with escaped newlines Now both paths use repo.iter_commits() with after/before kwargs, producing a unified clean format: raw hash, "Name <email>" author, full message body. Fixes modelcontextprotocol#4469
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4469
repo.iter_commits()call withafter/beforekwargs!rrepr formatting — output now uses clean hex SHA,Name <email>author format, and stripped commit messages in both casesrepo.git.log()path that produced different output formattest_git_log_consistent_formattest verifying both paths produce identical output structureTest plan
git_logcalls produce identical output formatName <email>consistently