Repository navigation
Conversation
Contributor
|
@jamadeo is on triage rotation this week and is the reviewer for this one. Labels come from the PR labeler. Please review the change. Automated triage. Labels are a first pass and the assigned maintainer has the final say. |
DaleSeo
force-pushed
the
DaleSeo/return-merged-cache-hints-from-list_all_-client
branch
from
November 3, 2026 16:33
71c0612 to
94a6ae8
Compare
DaleSeo
marked this pull request as ready for review
November 3, 2026 16:35
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1411.
Motivation and Context
list_all_*follows the cursors across pages and returns only the items, so it loses thettlMsandcacheScopefrom each page (SEP-2549). That means clients usinglist_all_*can't cache the merged list correctly.This PR Adds
*_with_cache_hintvariants of the fivePeer::list_all_*methods. They return aMergedList<T>with the items plus attl_msandcache_scopethat cover every page.The client response cache now reports
ttlMsas the time remaining before an entry expires, rather than the server's original value. If a re-fetch fails and the cache serves a stale entry, it reports0. Otherwise, a walk that hits the cache, which is enabled by default, could make the list seem fresher than it is. If a response doesn't includettlMs, it stays that way, so the cache'sdefault_ttlisn't shown as a server hint.How Has This Been Tested?
Added tests
Breaking Changes
None
Types of changes
Checklist
Additional context
In the next major release,
list_all_*could returnMergedList<T>directly, and we could remove the five_with_cache_hintmethods. Since that would be a breaking change, it’s being tracked separately in #1430.