Skip to content

fix: streamable-http server: stateful session workers ignore config.cancellation_token and stay alive until keep_alive after shutdown - #1427

Merged
jamadeo merged 1 commit into
modelcontextprotocol:mainfrom
xixi-box:fix/issue-1426-3fc54d0
Nov 3, 2026
Merged

jamadeo merged 1 commit into
modelcontextprotocol:mainfrom
xixi-box:fix/issue-1426-3fc54d0

Conversation

@xixi-box

@xixi-box xixi-box commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Fixes #1426

Verified by running the failing test at 3fc54d0aa133 (fails) and again with this patch applied (passes).

Signed-off-by: wangshun <96341168+xixi-box@users.noreply.github.com>
@xixi-box
xixi-box requested a review from a team as a code owner November 3, 2026 06:46
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-03T06:49:07.011512Z 20b01a2 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions github-actions Bot added T-core Core library changes T-transport Transport layer changes labels Nov 3, 2026
@github-actions
github-actions Bot requested a review from jamadeo November 3, 2026 06:46
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

@jamadeo is on triage rotation this week and is the reviewer for this one.

Labels come from the PR labeler. Please review the change.

Automated triage. Labels are a first pass and the assigned maintainer has the final say.

@jamadeo
jamadeo merged commit 8878a79 into modelcontextprotocol:main Nov 3, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-core Core library changes T-transport Transport layer changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

streamable-http server: stateful session workers ignore config.cancellation_token and stay alive until keep_alive after shutdown

2 participants